Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more default LOTR mod ExtensibleEnums #140

Merged
merged 3 commits into from
Apr 28, 2024

Conversation

XJIuPa
Copy link
Contributor

@XJIuPa XJIuPa commented Apr 22, 2024

Add LOTR Enums

Add LOTR Enums
@Dream-Master Dream-Master requested a review from a team April 23, 2024 20:36
@mist475
Copy link
Contributor

mist475 commented Apr 24, 2024

The formatter wants you to put multiple entries on the same line like this:

"net.minecraft.event.HoverEvent$Action", "lotr.common.fac.LOTRFaction",
"lotr.common.quest.LOTRMiniQuestFactory", "lotr.common.world.map.LOTRWaypoint",
"lotr.common.world.map.LOTRWaypoint$Region", "lotr.common.world.spawning.LOTRInvasions",
"lotr.common.LOTRShields", "lotr.common.LOTRDimension$DimensionRegion",
"lotr.common.item.LOTRItemBanner$BannerType", "lotr.common.LOTRAchievement$Category",

It would be nice if you add what addon/version of lotr requires this,
Default lotr doesn't need it so I presume some modified version/addon needs it?

@eigenraven eigenraven changed the title Update EarlyConfig.java Add more default LOTR mod ExtensibleEnums Apr 24, 2024
@XJIuPa
Copy link
Contributor Author

XJIuPa commented Apr 25, 2024

LOTR v36.14

@XJIuPa
Copy link
Contributor Author

XJIuPa commented Apr 25, 2024

Without these multiple entries, my client would not start at all.

@mist475
Copy link
Contributor

mist475 commented Apr 25, 2024

I use lotr 36.14 without these and it works fine. What other mods do you use? If you use any lotr addons that's why it's not working, so the name of that addon should be added to the comment for clarity.
In my opinion this should also be done to the LOTRFaction listing as that's only needed when LOTweakR is used. I'll add a note at some point for that myself

@eigenraven eigenraven enabled auto-merge (squash) April 28, 2024 06:26
@eigenraven eigenraven merged commit 3e1b8a3 into GTNewHorizons:master Apr 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants